phorge-arcanist/src/lint/linter/__tests__/xml/languages-6.lint-test

<?xml version="1.0" encoding="utf-8"?>
<languages>
    </lang>
</languages>
~~~~~~~~~~
error:3:16:XML76:LibXML Error
error:4:1:XML5:LibXML Error
Add an XML linter. Summary: Add a linter which uses [[http://php.net/simplexml \| SimpleXML]] to detect errors and potential problems in XML files. Test Plan: Wrote and executed unit tests. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8989 2014-05-05 20:15:53 -07:00			`<?xml version="1.0" encoding="utf-8"?>`
			`<languages>`
			`</lang>`
			`</languages>`
			`~~~~~~~~~~`
Modify the `lint-test` file format to allow for more powerful assertions Summary: Fixes T6854. The current format for `lint-test` files is somewhat inflexible and does not allow us to make assertions regarding the code or name of the linter messages (of class `ArcanistLintMessage`) that are raised. Specifically, the `${severity}:${line}:${char}` format is hardcoded in `ArcanistLinterTestCase`. In this diff, I extend the this format to achieve the following goals: - Allow for the lint message code and name to be specified. Specifically, the full format is `${severity}:${line}:${char}:${code}:${name}`. - Make all fields optional. `error:3:` will match any and all errors occuring on line 3. - Provide more useful output when assertions fail. Specifically, output //all// lint messages that are missing and/or surplus. Previously, only the first lint message was output. Test Plan: `arc unit` Reviewers: #blessed_reviewers, epriestley, chad Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6854 Differential Revision: https://secure.phabricator.com/D11176 2019-05-21 11:27:37 +10:00			`error:3:16:XML76:LibXML Error`
			`error:4:1:XML5:LibXML Error`