revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Simplify code by not passing local data to methods

Browse source
This commit is contained in:
vrana 2012-12-12 14:21:06 -08:00
parent 48077c80f2
commit 02694d73ab
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/workflow/ArcanistBranchWorkflow.php
View file

@ -71,7 +71,7 @@ EOTEXT
throw new ArcanistUsageException('No branches in this working copy.'); throw new ArcanistUsageException('No branches in this working copy.');
} }
$branches = $this->loadCommitInfo($branches, $repository_api); $branches = $this->loadCommitInfo($branches);
$revisions = $this->loadRevisions($branches); $revisions = $this->loadRevisions($branches);
@ -80,9 +80,8 @@ EOTEXT
return 0; return 0;
} }
private function loadCommitInfo( private function loadCommitInfo(array $branches) {
array $branches, $repository_api = $this->getRepositoryAPI();
ArcanistRepositoryAPI $repository_api) {
$futures = array(); $futures = array();
foreach ($branches as $branch) { foreach ($branches as $branch) {