revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-09-20 08:58:55 +02:00
Code Issues Releases Wiki Activity

Suppress stdin message if input is piped

Browse source 
Summary: Currently we output "Waiting for JSON parameters on stdin...", even if `stdin` is piped (for example, from `echo`).

Test Plan:
```lang=bash
> echo '{}' | arc call-conduit conduit.ping
{"error":null,"errorMessage":null,"response":"ip-10-161-81-110"}

> arc call-conduit conduit.ping
Waiting for JSON parameters on stdin...
{}
^D
{"error":null,"errorMessage":null,"response":"ip-10-161-81-110"}
```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11122
This commit is contained in:
Joshua Spence 2015-01-02 11:36:24 +11:00
parent f86a70f411
commit 0352db802e
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/workflow/ArcanistCallConduitWorkflow.php
View file

@ -61,7 +61,11 @@ EOTEXT
$method = reset($method);
$console = PhutilConsole::getConsole();
$console->writeErr("%s\n", pht('Waiting for JSON parameters on stdin...'));
if (!function_exists('posix_isatty') || posix_isatty(STDIN)) {
$console->writeErr(
"%s\n",
pht('Waiting for JSON parameters on stdin...'));
}
$params = @file_get_contents('php://stdin');
$params = json_decode($params, true);
if (!is_array($params)) {