From 0583b39bb040c272b4cdd906653f1092d0282ee8 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 12 May 2014 05:06:14 -0700 Subject: [PATCH] Minor tweaks for XHPAST config Summary: Ref T2039. The type specs are right in theory but not quite correct in practice, since we pass strings in rather than objects. Test Plan: While tweaking `phabricator/`, adjusted these to get desirable results. Reviewers: btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T2039 Differential Revision: https://secure.phabricator.com/D9071 --- src/lint/linter/ArcanistXHPASTLinter.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php index 51fd79db..94850ab6 100644 --- a/src/lint/linter/ArcanistXHPASTLinter.php +++ b/src/lint/linter/ArcanistXHPASTLinter.php @@ -147,12 +147,16 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter { public function getLinterConfigurationOptions() { return parent::getLinterConfigurationOptions() + array( 'xhpast.naminghook' => array( - 'type' => 'optional ArcanistXHPASTLintNamingHook', - 'help' => pht(''), + 'type' => 'optional string', + 'help' => pht( + 'Name of a concrete subclass of ArcanistXHPASTLintNamingHook which '. + 'enforces more granular naming convention rules for symbols.'), ), 'xhpast.switchhook' => array( - 'type' => 'optional ArcanistXHPASTLintSwitchHook', - 'help' => pht(''), + 'type' => 'optional string', + 'help' => pht( + 'Name of a concrete subclass of ArcanistXHPASTLintSwitchHook which '. + 'tunes the analysis of switch() statements for this linter.'), ), ); }