revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Fix arc lint amend for git to not add untracked files

Browse source 
Summary:
Arc lint for git is currently adding all untracked files when it
amends the commit with lint fixes. This changes the git add -A to be
git add -u. This only adds files that were already tracked. -A was adding
untracked files as well which was not the desired behavior here.

Test Plan:
Create an untracked file.
Commit a lint failure another file.

arc diff and choose to amend the lint patches.

Verify that the untracked file was not added but the tracked file was amended.

Reviewers: epriestley, wez, chad

Reviewed By: chad

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5731
This commit is contained in:
durham 2013-04-18 20:03:26 -07:00
parent fb88bb9da6
commit 07fba2a49b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistLintWorkflow.php
View file

@ -481,7 +481,7 @@ EOTEXT
if ($amend) { if ($amend) {
if ($repository_api instanceof ArcanistGitAPI) { if ($repository_api instanceof ArcanistGitAPI) {
// Add the changes to the index before amending // Add the changes to the index before amending
$repository_api->execxLocal('add -A'); $repository_api->execxLocal('add -u');
} }
$repository_api->amendCommit(); $repository_api->amendCommit();