Fix ArcanistLinterTestCase

Summary: We could also inject the value from the test case config but this is simpler.

Test Plan:
  $ arc unit src/lint/linter/ArcanistLicenseLinter.php

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2035

Differential Revision: https://secure.phabricator.com/D3895

src/lint/linter/ArcanistLicenseLinter.php

@@ -35,8 +35,11 @@ abstract class ArcanistLicenseLinter extends ArcanistLinter {
   abstract protected function getLicensePatterns();
 
   public function lintPath($path) {
-    $working_copy = $this->getEngine()->getWorkingCopy();
-    $copyright_holder = $working_copy->getConfig('copyright_holder');
+    $copyright_holder = $this->getConfig('copyright_holder');
+    if ($copyright_holder === null) {
+      $working_copy = $this->getEngine()->getWorkingCopy();
+      $copyright_holder = $working_copy->getConfig('copyright_holder');
+    }
 
     if (!$copyright_holder) {
       return;

src/lint/linter/ArcanistLinter.php

@@ -17,12 +17,22 @@ abstract class ArcanistLinter {
   protected $stopAllLinters = false;
 
   private $customSeverityMap = array();
+  private $config = array();
 
   public function setCustomSeverityMap(array $map) {
     $this->customSeverityMap = $map;
     return $this;
   }
 
+  public function setConfig(array $config) {
+    $this->config = $config;
+    return $this;
+  }
+
+  protected function getConfig($key, $default = null) {
+    return idx($this->config, $key, $default);
+  }
+
   public function getActivePath() {
     return $this->activePath;
   }

src/lint/linter/__tests__/ArcanistLinterTestCase.php

@@ -68,6 +68,7 @@ abstract class ArcanistLinterTestCase extends ArcanistTestCase {
 
       $linter->addPath($path);
       $linter->addData($path, $data);
+      $linter->setConfig(idx($config, 'config', array()));
 
       $engine->addLinter($linter);
       $engine->addFileData($path, $data);

src/lint/linter/__tests__/apachelicense/c-basic.lint-test

@@ -27,3 +27,5 @@ error:1:1
 int main(int argv, char **argv) {
   return 0;
 }
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/greedy.lint-test

@@ -35,3 +35,5 @@ function Copyright(Copyright $copyright) {
 }
 
 /* More Comments */
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/php-basic.lint-test

@@ -23,3 +23,5 @@ error:1:1
  */
 
 do_stuff();
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/php-script.lint-test

@@ -25,3 +25,5 @@ error:1:1
  */
 
 do_stuff();
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/php-update-mess.lint-test

@@ -27,3 +27,5 @@ error:1:1
  */
 
 do_stuff();
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/php-update-multi.lint-test

@@ -25,3 +25,5 @@ error:1:1
  */
 
 do_stuff();
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}

src/lint/linter/__tests__/apachelicense/php-update-single.lint-test

@@ -25,3 +25,5 @@ error:1:1
  */
 
 do_stuff();
+~~~~~~~~~~
+{"config": {"copyright_holder": "Facebook, Inc."}}