mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
Remove the "--less-context" flag from "arc diff"
Summary: Ref T13544. This is an obscure flag and almost never useful. You can accomplish the same goal, roughly, with "git diff | arc diff --raw -". See also PHI675. See also T13338. Test Plan: Grepped for "less-context", created this revision. Maniphest Tasks: T13544 Differential Revision: https://secure.phabricator.com/D21301
This commit is contained in:
parent
466de2d2e1
commit
0a4a841f8f
1 changed files with 0 additions and 18 deletions
|
@ -118,7 +118,6 @@ EOTEXT
|
||||||
'many Arcanist/Phabricator features which depend on having access '.
|
'many Arcanist/Phabricator features which depend on having access '.
|
||||||
'to the working copy.'),
|
'to the working copy.'),
|
||||||
'conflicts' => array(
|
'conflicts' => array(
|
||||||
'less-context' => null,
|
|
||||||
'apply-patches' => pht('%s disables lint.', '--raw'),
|
'apply-patches' => pht('%s disables lint.', '--raw'),
|
||||||
'never-apply-patches' => pht('%s disables lint.', '--raw'),
|
'never-apply-patches' => pht('%s disables lint.', '--raw'),
|
||||||
|
|
||||||
|
@ -142,7 +141,6 @@ EOTEXT
|
||||||
'working copy. This disables many Arcanist/Phabricator features '.
|
'working copy. This disables many Arcanist/Phabricator features '.
|
||||||
'which depend on having access to the working copy.'),
|
'which depend on having access to the working copy.'),
|
||||||
'conflicts' => array(
|
'conflicts' => array(
|
||||||
'less-context' => null,
|
|
||||||
'apply-patches' => pht('%s disables lint.', '--raw-command'),
|
'apply-patches' => pht('%s disables lint.', '--raw-command'),
|
||||||
'never-apply-patches' => pht('%s disables lint.', '--raw-command'),
|
'never-apply-patches' => pht('%s disables lint.', '--raw-command'),
|
||||||
),
|
),
|
||||||
|
@ -202,14 +200,6 @@ EOTEXT
|
||||||
'allow-untracked' => array(
|
'allow-untracked' => array(
|
||||||
'help' => pht('Skip checks for untracked files in the working copy.'),
|
'help' => pht('Skip checks for untracked files in the working copy.'),
|
||||||
),
|
),
|
||||||
'less-context' => array(
|
|
||||||
'help' => pht(
|
|
||||||
"Normally, files are diffed with full context: the entire file is ".
|
|
||||||
"sent to Differential so reviewers can 'show more' and see it. If ".
|
|
||||||
"you are making changes to very large files with tens of thousands ".
|
|
||||||
"of lines, this may not work well. With this flag, a diff will ".
|
|
||||||
"be created that has only a few lines of context."),
|
|
||||||
),
|
|
||||||
'apply-patches' => array(
|
'apply-patches' => array(
|
||||||
'help' => pht(
|
'help' => pht(
|
||||||
'Apply patches suggested by lint to the working copy without '.
|
'Apply patches suggested by lint to the working copy without '.
|
||||||
|
@ -597,9 +587,6 @@ EOTEXT
|
||||||
}
|
}
|
||||||
|
|
||||||
$repository_api = $this->getRepositoryAPI();
|
$repository_api = $this->getRepositoryAPI();
|
||||||
if ($this->getArgument('less-context')) {
|
|
||||||
$repository_api->setDiffLinesOfContext(3);
|
|
||||||
}
|
|
||||||
|
|
||||||
$repository_api->setBaseCommitArgumentRules(
|
$repository_api->setBaseCommitArgumentRules(
|
||||||
$this->getArgument('base', ''));
|
$this->getArgument('base', ''));
|
||||||
|
@ -925,11 +912,6 @@ EOTEXT
|
||||||
"Generally, source changes should not be this large.",
|
"Generally, source changes should not be this large.",
|
||||||
$change->getCurrentPath(),
|
$change->getCurrentPath(),
|
||||||
new PhutilNumber($size));
|
new PhutilNumber($size));
|
||||||
if (!$this->getArgument('less-context')) {
|
|
||||||
$byte_warning .= ' '.pht(
|
|
||||||
"If this file is a huge text file, try using the '%s' flag.",
|
|
||||||
'--less-context');
|
|
||||||
}
|
|
||||||
if ($repository_api instanceof ArcanistSubversionAPI) {
|
if ($repository_api instanceof ArcanistSubversionAPI) {
|
||||||
throw new ArcanistUsageException(
|
throw new ArcanistUsageException(
|
||||||
$byte_warning.' '.
|
$byte_warning.' '.
|
||||||
|
|
Loading…
Reference in a new issue