revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Performance improvements for linting in an HG repo.

Browse source 
Summary:
Run `hg status` as a Future while getting the diff. Add a cache for
getRawDiffText().

Test Plan:
Run `arc lint --trace` on a HG repo and confirm that `diff` is only called once
and `status` is run in the background.

Reviewers: epriestley

Reviewed By: epriestley

CC: yliang, dpepper, aran, Korvin

Maniphest Tasks: T2016

Differential Revision: https://secure.phabricator.com/D3913
This commit is contained in:
keegancsmith 2012-11-06 19:30:08 -08:00 committed by epriestley
parent ac92f9bdfc
commit 0a6444790d
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/repository/api/ArcanistMercurialAPI.php
View file

@ -14,6 +14,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
private $workingCopyRevision; private $workingCopyRevision;
private $localCommitInfo; private $localCommitInfo;
private $includeDirectoryStateInDiffs; private $includeDirectoryStateInDiffs;
private $rawDiffCache = array();
protected function buildLocalFuture(array $argv) { protected function buildLocalFuture(array $argv) {
@ -278,6 +279,10 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
// there is no way to get file change status across multiple commits, so // there is no way to get file change status across multiple commits, so
// just take the entire diff and parse it to figure out what's changed. // just take the entire diff and parse it to figure out what's changed.
// Execute status in the background
$status_future = $this->buildLocalFuture(array('status'));
$status_future->start();
$diff = $this->getFullMercurialDiff(); $diff = $this->getFullMercurialDiff();
if (!$diff) { if (!$diff) {
@ -311,7 +316,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
$status_map[$change->getCurrentPath()] = $flags; $status_map[$change->getCurrentPath()] = $flags;
} }
list($stdout) = $this->execxLocal('status'); list($stdout) = $status_future->resolvex();
$working_status = ArcanistMercurialParser::parseMercurialStatus($stdout); $working_status = ArcanistMercurialParser::parseMercurialStatus($stdout);
foreach ($working_status as $path => $status) { foreach ($working_status as $path => $status) {
@ -354,12 +359,19 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
$range .= '...'; $range .= '...';
} }
$raw_diff_cache_key = $options.' '.$range.' '.$path;
if (idx($this->rawDiffCache, $raw_diff_cache_key)) {
return idx($this->rawDiffCache, $raw_diff_cache_key);
}
list($stdout) = $this->execxLocal( list($stdout) = $this->execxLocal(
'diff %C --rev %s -- %s', 'diff %C --rev %s -- %s',
$options, $options,
$range, $range,
$path); $path);
$this->rawDiffCache[$raw_diff_cache_key] = $stdout;
return $stdout; return $stdout;
} }