From 0b8ea973aed7c5d652823522befcf504b17f5d2b Mon Sep 17 00:00:00 2001 From: Aviv Eyal Date: Mon, 30 Sep 2013 10:44:38 -0700 Subject: [PATCH] Fix coverage for NoseTestEngine Summary: In case that the $source_path is `.` or empty, it produces filenames that look like `./foo.py`, which differential doesn't like. Test Plan: arc diff, see coverage data. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7181 --- src/unit/engine/NoseTestEngine.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/unit/engine/NoseTestEngine.php b/src/unit/engine/NoseTestEngine.php index 00296a08..807e4161 100644 --- a/src/unit/engine/NoseTestEngine.php +++ b/src/unit/engine/NoseTestEngine.php @@ -127,6 +127,7 @@ final class NoseTestEngine extends ArcanistBaseUnitTestEngine { $relative_path = explode(".", $class->getAttribute("filename")); array_pop($relative_path); $relative_path = $source_path .'/'. implode("/", $relative_path); + $relative_path = Filesystem::readablePath($relative_path); // first we check if the path is a directory (a Python package), if it is // set relative and absolute paths to have __init__.py at the end.