revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Fix coverage for NoseTestEngine

Browse source 
Summary:
In case that the $source_path is `.` or empty, it produces filenames that
look like `./foo.py`, which differential doesn't like.

Test Plan: arc diff, see coverage data.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7181
This commit is contained in:
Aviv Eyal 2013-09-30 10:44:38 -07:00 committed by epriestley
parent aebcd7a985
commit 0b8ea973ae
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/unit/engine/NoseTestEngine.php
View file

@ -127,6 +127,7 @@ final class NoseTestEngine extends ArcanistBaseUnitTestEngine {
$relative_path = explode(".", $class->getAttribute("filename")); $relative_path = explode(".", $class->getAttribute("filename"));
array_pop($relative_path); array_pop($relative_path);
$relative_path = $source_path .'/'. implode("/", $relative_path); $relative_path = $source_path .'/'. implode("/", $relative_path);
$relative_path = Filesystem::readablePath($relative_path);
// first we check if the path is a directory (a Python package), if it is // first we check if the path is a directory (a Python package), if it is
// set relative and absolute paths to have __init__.py at the end. // set relative and absolute paths to have __init__.py at the end.