revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field

Browse source 
Summary:
This revision fixes a `trim(null)` exception when creating a diff with an empty
field.

Fixes: T15868

Test Plan:
1. Create a commit with an empty "Differential Revision:" field
2. Run `arc diff`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25703
This commit is contained in:
jkim 2024-06-27 10:57:07 +01:00
parent 0d5f437970
commit 0c9c94748b
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workflow/ArcanistDiffWorkflow.php
View file

@ -1938,6 +1938,10 @@ EOTEXT
continue; continue;
} }
if ($value === null) {
continue;
}
if (is_array($value)) { if (is_array($value)) {
// For array values, merge the arrays, appending the new values. // For array values, merge the arrays, appending the new values.
// Examples are "Reviewers" and "Cc", where this produces a list of // Examples are "Reviewers" and "Cc", where this produces a list of