mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 06:42:41 +01:00
Fix an issue where method prototypes have different signatures
Summary: PHP whines about this: > [2013-09-23 08:09:22] ERROR 2048: Declaration of CSharpToolsTestEngine::loadEnvironment() should be compatible with XUnitTestEngine::loadEnvironment($config_item = 'unit.xunit...') at [/INSECURE/devtools/arcanist/src/unit/engine/CSharpToolsTestEngine.php:13] Auditors: jamesr, btrahan
This commit is contained in:
parent
4ba895c30d
commit
0d0333d50a
1 changed files with 4 additions and 2 deletions
|
@ -23,14 +23,16 @@ final class CSharpToolsTestEngine extends XUnitTestEngine {
|
|||
* of configuration values and to pull in the cstools config for
|
||||
* code coverage.
|
||||
*/
|
||||
protected function loadEnvironment() {
|
||||
protected function loadEnvironment(
|
||||
$config_item = 'unit.csharp.xunit.binary') {
|
||||
|
||||
$working = $this->getWorkingCopy();
|
||||
$this->xunitHintPath = $working->getConfig('unit.csharp.xunit.binary');
|
||||
$this->cscoverHintPath = $working->getConfig('unit.csharp.cscover.binary');
|
||||
$this->matchRegex = $working->getConfig('unit.csharp.coverage.match');
|
||||
$this->excludedFiles = $working->getConfig('unit.csharp.coverage.excluded');
|
||||
|
||||
parent::loadEnvironment('unit.csharp.xunit.binary');
|
||||
parent::loadEnvironment($config_item);
|
||||
|
||||
if ($this->getEnableCoverage() === false) {
|
||||
return;
|
||||
|
|
Loading…
Reference in a new issue