revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-19 18:28:38 +01:00
Code Issues Releases Wiki Activity

Fix an issue where method prototypes have different signatures

Browse source 
Summary: PHP whines about this:

> [2013-09-23 08:09:22] ERROR 2048: Declaration of CSharpToolsTestEngine::loadEnvironment() should be compatible with XUnitTestEngine::loadEnvironment($config_item = 'unit.xunit...') at [/INSECURE/devtools/arcanist/src/unit/engine/CSharpToolsTestEngine.php:13]

Auditors: jamesr, btrahan
This commit is contained in:
epriestley 2013-09-23 08:34:28 -07:00
parent 4ba895c30d
commit 0d0333d50a
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/unit/engine/CSharpToolsTestEngine.php
View file

@ -23,14 +23,16 @@ final class CSharpToolsTestEngine extends XUnitTestEngine {
* of configuration values and to pull in the cstools config for * of configuration values and to pull in the cstools config for
* code coverage. * code coverage.
*/ */
protected function loadEnvironment() { protected function loadEnvironment(
$config_item = 'unit.csharp.xunit.binary') {
$working = $this->getWorkingCopy(); $working = $this->getWorkingCopy();
$this->xunitHintPath = $working->getConfig('unit.csharp.xunit.binary'); $this->xunitHintPath = $working->getConfig('unit.csharp.xunit.binary');
$this->cscoverHintPath = $working->getConfig('unit.csharp.cscover.binary'); $this->cscoverHintPath = $working->getConfig('unit.csharp.cscover.binary');
$this->matchRegex = $working->getConfig('unit.csharp.coverage.match'); $this->matchRegex = $working->getConfig('unit.csharp.coverage.match');
$this->excludedFiles = $working->getConfig('unit.csharp.coverage.excluded'); $this->excludedFiles = $working->getConfig('unit.csharp.coverage.excluded');
parent::loadEnvironment('unit.csharp.xunit.binary'); parent::loadEnvironment($config_item);
if ($this->getEnableCoverage() === false) { if ($this->getEnableCoverage() === false) {
return; return;