revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

canRun should return false on scala linter instead of raising an exception

Browse source 
Summary:
This was causing the following error in environments that didnt have scala configured:

Some linters failed:
   - ArcanistScalaSBTLinter: ArcanistUsageException: This directory does not appear to be maintained by SBT, as we can't seem to find a working build file (project/Build.scala or build.sbt).

Test Plan: .

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4070
This commit is contained in:
David Cramer 2012-12-03 15:25:16 -08:00 committed by epriestley
parent 3602d2aa15
commit 0d1d04e434
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/lint/linter/ArcanistScalaSBTLinter.php
View file

@ -30,10 +30,7 @@ final class ArcanistScalaSBTLinter extends ArcanistLinter {
// Hell. We let the build system handle this for us.
if (!Filesystem::pathExists('project/Build.scala') &&
!Filesystem::pathExists('build.sbt')) {
throw new ArcanistUsageException(
"This directory does not appear to be maintained by SBT, as we can't ".
"seem to find a working build file (project/Build.scala or ".
"build.sbt).");
return false;
}
return true;
}