revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-23 23:32:39 +01:00
Code Issues Releases Wiki Activity

Fix return value of PhutilTestCase::tryTestCaseMap()

Browse source 
Summary: `PhutilTestCase::tryTestCases()` returns void. Thus `PhutilTestCase::tryTestCaseMap()` should behave the same way as `PhutilTestCase::assertException()`: return void.

Test Plan: Read the code; run static code analysis and don't get "Result of method PhutilTestCase::tryTestCases() (void) is used" anymore.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25791
This commit is contained in:
Andre Klapper 2024-08-18 00:15:13 +02:00
parent 4752567130
commit 0d5f437970
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/unit/engine/phutil/PhutilTestCase.php
View file

@ -445,7 +445,7 @@ abstract class PhutilTestCase extends Phobject {
$callable, $callable,
$exception_class = 'Exception') { $exception_class = 'Exception') {
return $this->tryTestCases( $this->tryTestCases(
array_fuse(array_keys($map)), array_fuse(array_keys($map)),
array_values($map), array_values($map),
$callable, $callable,