revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 00:02:40 +01:00
Code Issues Releases Wiki Activity

Fix phutil_analyzer bug on interface dependency creation

Browse source 
Summary:
Use $interface_name instead of $class_name when dealing with
interfaces. Problem happens when you extend an interface:

    interface SubIface extends SuperIface { ...

    Notice: Undefined variable: class_name in ...
	Fatal error: Call to a member function getConcreteString() on a
	non-object in ...

Test Plan: phutil_mapper.php works!
This commit is contained in:
Felipe Oliveira Carvalho 2011-08-10 11:50:10 -03:00
parent 58c09ab36d
commit 0eab28fe1b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/phutil_analyzer.php
View file

@ -303,7 +303,7 @@ foreach (Futures($futures) as $file => $future) {
$extends = $interface->getChildByIndex(2); $extends = $interface->getChildByIndex(2);
foreach ($extends->selectDescendantsOfType('n_CLASS_NAME') as $parent) { foreach ($extends->selectDescendantsOfType('n_CLASS_NAME') as $parent) {
$requirements->addInterfaceDependency( $requirements->addInterfaceDependency(
$class_name->getConcreteString(), $interface_name->getConcreteString(),
$parent, $parent,
$parent->getConcreteString()); $parent->getConcreteString());
} }