From 10bcbf1f4bf8900338eac16bee1a4f852935d111 Mon Sep 17 00:00:00 2001 From: vrana Date: Wed, 21 Nov 2012 15:30:42 -0800 Subject: [PATCH] Emit advice for TODO in Phutil linter Summary: Let's try this. It may be useful to see this together in Differential overview. Test Plan: Linted a file with TODO. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T744 Differential Revision: https://secure.phabricator.com/D4014 --- src/lint/engine/PhutilLintEngine.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lint/engine/PhutilLintEngine.php b/src/lint/engine/PhutilLintEngine.php index 360b6ca2..0c806b79 100644 --- a/src/lint/engine/PhutilLintEngine.php +++ b/src/lint/engine/PhutilLintEngine.php @@ -56,14 +56,15 @@ class PhutilLintEngine extends ArcanistLintEngine { private function getXHPASTSeverityMap() { $error = ArcanistLintSeverity::SEVERITY_ERROR; $warning = ArcanistLintSeverity::SEVERITY_WARNING; + $advice = ArcanistLintSeverity::SEVERITY_ADVICE; return array( ArcanistXHPASTLinter::LINT_PHP_53_FEATURES => $error, ArcanistXHPASTLinter::LINT_PHP_54_FEATURES => $error, ArcanistXHPASTLinter::LINT_PHT_WITH_DYNAMIC_STRING => $error, ArcanistXHPASTLinter::LINT_COMMENT_SPACING => $error, - ArcanistXHPASTLinter::LINT_RAGGED_CLASSTREE_EDGE => $warning, + ArcanistXHPASTLinter::LINT_TODO_COMMENT => $advice, ); } }