From b1de04aa68363e85336932b3b61a96fd9f907e0d Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 29 Feb 2016 08:02:37 -0800 Subject: [PATCH 1/2] Report unit test details from Arcanist to Harbormaster Summary: Ref T10457. Provides information for D15363. Test Plan: See D15363. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9951, T10457 Differential Revision: https://secure.phabricator.com/D15364 --- src/workflow/ArcanistWorkflow.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/workflow/ArcanistWorkflow.php b/src/workflow/ArcanistWorkflow.php index ad57c843..f30fdc47 100644 --- a/src/workflow/ArcanistWorkflow.php +++ b/src/workflow/ArcanistWorkflow.php @@ -2036,6 +2036,13 @@ abstract class ArcanistWorkflow extends Phobject { protected function getModernUnitDictionary(array $map) { $map = $this->getModernCommonDictionary($map); + + $details = idx($map, 'userData'); + if (strlen($details)) { + $map['details'] = (string)$details; + } + unset($map['userData']); + return $map; } From 3876d9358390ee9a6290689ca38d8a1e972233b8 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 4 Mar 2016 15:49:35 -0800 Subject: [PATCH 2/2] Properly URL encode branches in `arc browse --branch ...` Summary: Fixes T10511. If you `arc browse --branch x/y/z`, we do not encode the URI properly. Test Plan: Ran `arc browse --branch x/y/z/ something.c`. Before, got an error about "x" does not exist. This is wrong; the error should be about "x/y/z". After, got the proper error: {F1141096} Reviewers: chad, avivey Reviewed By: avivey Maniphest Tasks: T10511 Differential Revision: https://secure.phabricator.com/D15397 --- src/workflow/ArcanistBrowseWorkflow.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/workflow/ArcanistBrowseWorkflow.php b/src/workflow/ArcanistBrowseWorkflow.php index 76aa66dd..64d8f84a 100644 --- a/src/workflow/ArcanistBrowseWorkflow.php +++ b/src/workflow/ArcanistBrowseWorkflow.php @@ -225,6 +225,7 @@ EOTEXT } $branch = $this->getArgument('branch', 'master'); + $branch = phutil_escape_uri_path_component($branch); return $repo_uri.'browse/'.$branch.'/'; }