From 146693307f607ffa93dfb99599f1989d5b27e03d Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Thu, 20 Apr 2017 14:50:03 -0700 Subject: [PATCH] Make exception reporting from `arc` be in red Summary: Many other status updates (such as "Builds passed!") show up in bright background colors, making them more salient than a final fatal "Exception". Make exception reporting be just as colorful, so it stands out. Test Plan: Added an explicit `throw new Exception("!!!")` and saw it in red. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D17748 --- scripts/arcanist.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/arcanist.php b/scripts/arcanist.php index dc2f07b7..c0ae4d8c 100755 --- a/scripts/arcanist.php +++ b/scripts/arcanist.php @@ -422,7 +422,8 @@ try { } if (!$is_usage) { - fwrite(STDERR, phutil_console_format("**%s**\n", pht('Exception'))); + fwrite(STDERR, phutil_console_format( + "** %s **\n", pht('Exception'))); while ($ex) { fwrite(STDERR, $ex->getMessage()."\n");