From 14e5fbbd6bfd3c3b8c7ba6f85437bbcd3241fde9 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 12 Jan 2015 06:44:08 +1100 Subject: [PATCH] Fix parsing of `puppet-lint --version` Summary: This seems to be off, at least for `puppet-lint` versions greater than 1.0. Test Plan: `arc unit` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11312 --- src/lint/linter/ArcanistPuppetLintLinter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lint/linter/ArcanistPuppetLintLinter.php b/src/lint/linter/ArcanistPuppetLintLinter.php index be2e6076..bc8145c4 100644 --- a/src/lint/linter/ArcanistPuppetLintLinter.php +++ b/src/lint/linter/ArcanistPuppetLintLinter.php @@ -38,7 +38,7 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter { list($stdout) = execx('%C --version', $this->getExecutableCommand()); $matches = array(); - $regex = '/^Puppet-lint (?P\d+\.\d+\.\d+)$/'; + $regex = '/^puppet-lint (?P\d+\.\d+\.\d+)$/'; if (preg_match($regex, $stdout, $matches)) { return $matches['version']; } else {