From 187e10e7810b220589eaa76053abcac932b5d2dd Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Fri, 20 Nov 2015 10:27:21 +1100 Subject: [PATCH] Fix parsing of `ruby` version for `ArcanistRubyLinter` Summary: This fails to extract the version correctly locally. ``` > ruby --version ruby 1.8.7 (2014-01-28 patchlevel 376) [x86_64-linux] ``` Test Plan: `arc unit` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14525 --- src/lint/linter/ArcanistRubyLinter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lint/linter/ArcanistRubyLinter.php b/src/lint/linter/ArcanistRubyLinter.php index bb29f381..df4b0503 100644 --- a/src/lint/linter/ArcanistRubyLinter.php +++ b/src/lint/linter/ArcanistRubyLinter.php @@ -35,7 +35,7 @@ final class ArcanistRubyLinter extends ArcanistExternalLinter { list($stdout) = execx('%C --version', $this->getExecutableCommand()); $matches = array(); - $regex = '/^ruby (?P\d+\.\d+\.\d+)p\d+/'; + $regex = '/^ruby (?P\d+\.\d+\.\d+)+/'; if (preg_match($regex, $stdout, $matches)) { return $matches['version']; } else {