From 1b3d60009819af61ea16eba7078ded202ce44d88 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 12 Jan 2015 06:46:34 +1100 Subject: [PATCH] Don't pass `--quiet` to `csslint` Summary: Similar to D11198. This flag doesn't do anything when combined with `--format=lint-xml`. Test Plan: ```lang=bash > csslint *.css csslint *.css csslint: There are 1 problems in /home/joshua/workspace/github.com/phacility/arcanist/fail.css. fail.css 1: error at line 1, col 1 Unexpected token '~' at line 1, col 1. ~ csslint: No errors in /home/joshua/workspace/github.com/phacility/arcanist/pass.css. > csslint --quiet *.css csslint --quiet *.css csslint: There are 1 problems in /home/joshua/workspace/github.com/phacility/arcanist/fail.css. fail.css 1: error at line 1, col 1 Unexpected token '~' at line 1, col 1. ~ > csslint --format=lint-xml *.css > csslint --format=lint-xml --quiet *.css ``` Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11308 --- src/lint/linter/ArcanistCSSLintLinter.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php index 45bb0f4e..8351fb2b 100644 --- a/src/lint/linter/ArcanistCSSLintLinter.php +++ b/src/lint/linter/ArcanistCSSLintLinter.php @@ -28,7 +28,6 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter { protected function getMandatoryFlags() { return array( '--format=lint-xml', - '--quiet', ); }