From 1b4a3e0c5eb94dafaee3dad2752bbb30db8b8350 Mon Sep 17 00:00:00 2001
From: Vihang Mehta <vihang@trifacta.com>
Date: Fri, 2 Oct 2015 08:58:15 -0700
Subject: [PATCH] Set path on more linters

Summary:
This is in a similar vein as D14220 and sets a name on linter
messages. This should handle issues from D14165.

Test Plan: Run as many of the changed linters as possible + existing linter tests.

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14225
---
 src/lint/linter/ArcanistCSSLintLinter.php  | 1 +
 src/lint/linter/ArcanistGoLintLinter.php   | 1 +
 src/lint/linter/ArcanistJSONLintLinter.php | 1 +
 src/lint/linter/ArcanistJscsLinter.php     | 1 +
 src/lint/linter/ArcanistPyFlakesLinter.php | 1 +
 5 files changed, 5 insertions(+)

diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php
index 7436b194..a7583959 100644
--- a/src/lint/linter/ArcanistCSSLintLinter.php
+++ b/src/lint/linter/ArcanistCSSLintLinter.php
@@ -72,6 +72,7 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter {
           ->setLine($child->getAttribute('line'))
           ->setChar($child->getAttribute('char'))
           ->setCode($this->getLinterName())
+          ->setName($this->getLinterName())
           ->setDescription($child->getAttribute('reason'))
           ->setOriginalText(
             substr(
diff --git a/src/lint/linter/ArcanistGoLintLinter.php b/src/lint/linter/ArcanistGoLintLinter.php
index 0252d4c9..419acf41 100644
--- a/src/lint/linter/ArcanistGoLintLinter.php
+++ b/src/lint/linter/ArcanistGoLintLinter.php
@@ -53,6 +53,7 @@ final class ArcanistGoLintLinter extends ArcanistExternalLinter {
         $message->setLine($matches[1]);
         $message->setChar($matches[2]);
         $message->setCode($this->getLinterName());
+        $message->setName($this->getLinterName());
         $message->setDescription(ucfirst(trim($matches[3])));
         $message->setSeverity(ArcanistLintSeverity::SEVERITY_ADVICE);
 
diff --git a/src/lint/linter/ArcanistJSONLintLinter.php b/src/lint/linter/ArcanistJSONLintLinter.php
index 7fd00254..7a157d61 100644
--- a/src/lint/linter/ArcanistJSONLintLinter.php
+++ b/src/lint/linter/ArcanistJSONLintLinter.php
@@ -72,6 +72,7 @@ final class ArcanistJSONLintLinter extends ArcanistExternalLinter {
         $message->setLine($matches['line']);
         $message->setChar($matches['column']);
         $message->setCode($this->getLinterName());
+        $message->setName($this->getLinterName());
         $message->setDescription(ucfirst($matches['description']));
         $message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);
 
diff --git a/src/lint/linter/ArcanistJscsLinter.php b/src/lint/linter/ArcanistJscsLinter.php
index 338e08d3..88f046b7 100644
--- a/src/lint/linter/ArcanistJscsLinter.php
+++ b/src/lint/linter/ArcanistJscsLinter.php
@@ -109,6 +109,7 @@ final class ArcanistJscsLinter extends ArcanistExternalLinter {
         $message->setLine($error->getAttribute('line'));
         $message->setChar($error->getAttribute('column'));
         $message->setCode('JSCS');
+        $message->setName('JSCS');
         $message->setDescription($error->getAttribute('message'));
 
         switch ($error->getAttribute('severity')) {
diff --git a/src/lint/linter/ArcanistPyFlakesLinter.php b/src/lint/linter/ArcanistPyFlakesLinter.php
index c312487c..e8a37a79 100644
--- a/src/lint/linter/ArcanistPyFlakesLinter.php
+++ b/src/lint/linter/ArcanistPyFlakesLinter.php
@@ -71,6 +71,7 @@ final class ArcanistPyFlakesLinter extends ArcanistExternalLinter {
       $message->setPath($path);
       $message->setLine($matches[2]);
       $message->setCode($this->getLinterName());
+      $message->setName($this->getLinterName());
       $message->setDescription($description);
       $message->setSeverity($severity);