From 1bb2409d473b4b3892a00c9e6a155811a267b9dd Mon Sep 17 00:00:00 2001 From: Jason Ge Date: Mon, 25 Jul 2011 16:24:23 -0700 Subject: [PATCH] Remove the size limit on arc side Summary: remove the size check. The conduit call will fail later if the size is too large, and we will get better error message. Test Plan: run arc diff with files smaller and larger than the size limit. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 729 --- src/workflow/diff/ArcanistDiffWorkflow.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/workflow/diff/ArcanistDiffWorkflow.php b/src/workflow/diff/ArcanistDiffWorkflow.php index f5ddd206..bf365d9f 100644 --- a/src/workflow/diff/ArcanistDiffWorkflow.php +++ b/src/workflow/diff/ArcanistDiffWorkflow.php @@ -819,12 +819,6 @@ EOTEXT $mime_type = trim($mime_type); $result['mime'] = $mime_type; - // TODO: Make this configurable. - $bin_limit = 1024 * 1024; // 1 MB limit - if (strlen($data) > $bin_limit) { - return $result; - } - $bytes = strlen($data); echo "Uploading {$desc} '{$name}' ({$mime_type}, {$bytes} bytes)...\n";