From 1c327208d7ba4286930ea64299d732bec2b44f56 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 4 Sep 2020 17:01:21 -0700 Subject: [PATCH] Fix a missing "pht()" parameter in HTTPSFuture Summary: Ref T13577. This call is missing a parameter. After D21453, this is detected properly by lint. Provide the parameter. Test Plan: Ran `arc lint` on HTTPSFuture before and after the change. Maniphest Tasks: T13577 Differential Revision: https://secure.phabricator.com/D21454 --- src/future/http/HTTPSFuture.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/future/http/HTTPSFuture.php b/src/future/http/HTTPSFuture.php index e1f37cce..c217c112 100644 --- a/src/future/http/HTTPSFuture.php +++ b/src/future/http/HTTPSFuture.php @@ -132,7 +132,7 @@ final class HTTPSFuture extends BaseHTTPFuture { * @return string|false */ public static function loadContent($uri, $timeout = null) { - $future = new HTTPSFuture($uri); + $future = new self($uri); if ($timeout !== null) { $future->setTimeout($timeout); } @@ -151,7 +151,8 @@ final class HTTPSFuture extends BaseHTTPFuture { throw new Exception( pht( 'Specified download path "%s" already exists, refusing to '. - 'overwrite.')); + 'overwrite.', + $download_path)); } return $this;