From 1d3266395f705e742ad5c966280de53e2e7b05d5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 24 Aug 2015 21:07:28 -0700 Subject: [PATCH] Remove two problematic XML linter unit tests Summary: Fixes T7215. See D13991. These test cases have been failing intermittently for a while. I think the XML stuff (which we don't control) changed where it raises these warnings: an old version raised them at the end of the attribute, while the new version raises them at the beginning of the attribute. Not totally 100% sure about this since installing multiple versions is fairly inconvenient, but as far as I know both versions raise the warnings, just at different character offsets. We could do various things to fix these tests (allow the warning to raise at any character, skip the tests based on versions, etc) but I think it's easier to just remove the tests. They don't seem valuable. Test Plan: Tests failed prior to change; now pass. Reviewers: chad, joshuaspence Reviewed By: joshuaspence Maniphest Tasks: T7215 Differential Revision: https://secure.phabricator.com/D13992 --- src/lint/linter/__tests__/xml/attr3.lint-test | 8 -------- src/lint/linter/__tests__/xml/attr4.lint-test | 3 --- 2 files changed, 11 deletions(-) delete mode 100644 src/lint/linter/__tests__/xml/attr3.lint-test delete mode 100644 src/lint/linter/__tests__/xml/attr4.lint-test diff --git a/src/lint/linter/__tests__/xml/attr3.lint-test b/src/lint/linter/__tests__/xml/attr3.lint-test deleted file mode 100644 index b4010298..00000000 --- a/src/lint/linter/__tests__/xml/attr3.lint-test +++ /dev/null @@ -1,8 +0,0 @@ - - - -]> - -~~~~~~~~~~ -warning:4:28 diff --git a/src/lint/linter/__tests__/xml/attr4.lint-test b/src/lint/linter/__tests__/xml/attr4.lint-test deleted file mode 100644 index e2c02992..00000000 --- a/src/lint/linter/__tests__/xml/attr4.lint-test +++ /dev/null @@ -1,3 +0,0 @@ - -~~~~~~~~~~ -error:1:15