mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 14:52:40 +01:00
Add Delete Flag to Paths ignore mask
Summary: When `arc diff` runs unit tests it uses all of the affected files as the base array of paths. These files may have been deleted. If the deleted file fits the test criteria `unit` will try and run the test and in some cases fail. An example of this fataling is with PHPUnit; > Fatal error: Uncaught exception 'Exception' with message 'JSON report file is em pty, it probably means that phpunit failed to run tests. Try running arc unit wi th --trace option and then run generated phpunit command yourself, you might get the answer.' in C:\Websites\facebook\arcanist\src\unit\engine\PhpunitResultPars er.php on line 156 Test Plan: Re-ran the tests that were causing issues with `arc unit --rev HEAD^ --trace` Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D6246
This commit is contained in:
parent
b713eb51c9
commit
1d5ee03fdb
1 changed files with 3 additions and 0 deletions
|
@ -57,6 +57,9 @@ final class PhpunitTestEngine extends ArcanistBaseUnitTestEngine {
|
|||
$futures = array();
|
||||
$tmpfiles = array();
|
||||
foreach ($this->affectedTests as $class_path => $test_path) {
|
||||
if(!Filesystem::pathExists($test_path)) {
|
||||
continue;
|
||||
}
|
||||
$json_tmp = new TempFile();
|
||||
$clover_tmp = null;
|
||||
$clover = null;
|
||||
|
|
Loading…
Reference in a new issue