From 1dd69bdbee5c995594101bccc8aaaaa6c61e67fd Mon Sep 17 00:00:00 2001
From: jungejason <jungejason@fb.com>
Date: Mon, 4 Apr 2011 16:26:46 -0700
Subject: [PATCH] Improve 'arc' error message when failing to load a library

Summary:
display better message about the .arcconfig. The message will
be something like this now:
  Usage Exception: Failed to load library "phabricator" at location
  "srcaaaaa/". Please check the "phutil_libraries" setting in your
  .arcconfig file. Refer to page
  http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html
  for more info.

Test Plan:
modify the .arcconfig file to test it. Also make sure it
works for correct settings.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, epriestley
Differential Revision: 99
---
 scripts/arcanist.php | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/arcanist.php b/scripts/arcanist.php
index 67d585b6..e70f23ba 100755
--- a/scripts/arcanist.php
+++ b/scripts/arcanist.php
@@ -89,7 +89,18 @@ try {
       if (Filesystem::pathExists($resolved_location)) {
         $location = $resolved_location;
       }
-      phutil_load_library($location);
+      try {
+        phutil_load_library($location);
+      } catch (PhutilBootloaderException $ex) {
+        $error_msg = sprintf(
+          'Failed to load library "%s" at location "%s". Please check the '.
+          '"phutil_libraries" setting in your .arcconfig file. Refer to page '.
+          'http://phabricator.com/docs/arcanist/article/'.
+          'Setting_Up_.arcconfig.html for more info.',
+          $name,
+          $location);
+        throw new ArcanistUsageException($error_msg);
+      }
     }
   }