revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-01 11:12:41 +01:00
Code Issues Releases Wiki Activity

Use more modern detection of repositories in "arc close-revision"

Browse source 
Summary:
Fixes T4603. We fire `arc close-revision --finalize` implicitly from `arc land`, which may close a corresponding Differential revision.

We want to close if the repository is not present in Phabricator (i.e., we'll never be able to close in response to the commit message, since we'll never see it). Historically, we used Arcanist Project -> "Tracked" to make this determination. Instead, just check if the working copy is associated with a repository. This is simpler, easier, and works better.

Test Plan: Ran `arc close-revision --finalize`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4603

Differential Revision: https://secure.phabricator.com/D8523
This commit is contained in:
epriestley 2014-03-13 18:01:53 -07:00
parent 03ddc17032
commit 1e6d958b27
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/workflow/ArcanistCloseRevisionWorkflow.php
View file

@ -112,8 +112,7 @@ EOTEXT
$actually_close = true; $actually_close = true;
if ($is_finalize) { if ($is_finalize) {
$project_info = $this->getProjectInfo(); if ($this->getRepositoryPHID() ||
if (idx($project_info, 'tracked') ||
$revision['status'] != $status_accepted) { $revision['status'] != $status_accepted) {
$actually_close = false; $actually_close = false;
} }