mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
Use PHP type hinting in ArcanistXHPASTLinter
.
Summary: Explicitly specify the types of the function parameters. This change is basically the same as D8388. Test Plan: `arc unit`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9040
This commit is contained in:
parent
edd85a0e9d
commit
20a0559522
1 changed files with 3 additions and 3 deletions
|
@ -107,7 +107,7 @@ final class ArcanistPhutilXHPASTLinter extends ArcanistBaseXHPASTLinter {
|
|||
}
|
||||
|
||||
|
||||
private function lintUnsafeDynamicString($root) {
|
||||
private function lintUnsafeDynamicString(XHPASTNode $root) {
|
||||
$safe = $this->dynamicStringFunctions + array(
|
||||
'pht' => 0,
|
||||
|
||||
|
@ -175,7 +175,7 @@ final class ArcanistPhutilXHPASTLinter extends ArcanistBaseXHPASTLinter {
|
|||
}
|
||||
|
||||
|
||||
private function lintArrayCombine($root) {
|
||||
private function lintArrayCombine(XHPASTNode $root) {
|
||||
$function_calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
|
||||
foreach ($function_calls as $call) {
|
||||
$name = $call->getChildByIndex(0)->getConcreteString();
|
||||
|
@ -200,7 +200,7 @@ final class ArcanistPhutilXHPASTLinter extends ArcanistBaseXHPASTLinter {
|
|||
}
|
||||
}
|
||||
|
||||
private function lintDeprecatedFunctions($root) {
|
||||
private function lintDeprecatedFunctions(XHPASTNode $root) {
|
||||
$map = $this->deprecatedFunctions;
|
||||
|
||||
$function_calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
|
||||
|
|
Loading…
Reference in a new issue