revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-17 01:08:40 +01:00
Code Issues Releases Wiki Activity

Change ArcanistLintRenderer to class

Browse source 
Summary: Renderers **are** renderers not **can** render.

Test Plan: This diff.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5092
This commit is contained in:
vrana 2013-02-22 16:12:53 -08:00
parent 5d47682f3b
commit 21a4574922
5 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/renderer/ArcanistLintConsoleRenderer.php
View file

@ -5,7 +5,7 @@
* *
* @group lint * @group lint
*/ */
final class ArcanistLintConsoleRenderer implements ArcanistLintRenderer { final class ArcanistLintConsoleRenderer extends ArcanistLintRenderer {
private $showAutofixPatches = false; private $showAutofixPatches = false;
public function setShowAutofixPatches($show_autofix_patches) { public function setShowAutofixPatches($show_autofix_patches) {

2
src/lint/renderer/ArcanistLintJSONRenderer.php
View file

@ -5,7 +5,7 @@
* *
* @group lint * @group lint
*/ */
final class ArcanistLintJSONRenderer implements ArcanistLintRenderer { final class ArcanistLintJSONRenderer extends ArcanistLintRenderer {
const LINES_OF_CONTEXT = 3; const LINES_OF_CONTEXT = 3;
public function renderLintResult(ArcanistLintResult $result) { public function renderLintResult(ArcanistLintResult $result) {

2
src/lint/renderer/ArcanistLintLikeCompilerRenderer.php
View file

@ -5,7 +5,7 @@
* *
* @group lint * @group lint
*/ */
final class ArcanistLintLikeCompilerRenderer implements ArcanistLintRenderer { final class ArcanistLintLikeCompilerRenderer extends ArcanistLintRenderer {
public function renderLintResult(ArcanistLintResult $result) { public function renderLintResult(ArcanistLintResult $result) {
$lines = array(); $lines = array();
$messages = $result->getMessages(); $messages = $result->getMessages();

8
src/lint/renderer/ArcanistLintRenderer.php
View file

@ -5,7 +5,9 @@
* *
* @group lint * @group lint
*/ */
interface ArcanistLintRenderer { abstract class ArcanistLintRenderer {
public function renderLintResult(ArcanistLintResult $result);
public function renderOkayResult(); abstract public function renderLintResult(ArcanistLintResult $result);
abstract public function renderOkayResult();
} }

2
src/lint/renderer/ArcanistLintSummaryRenderer.php
View file

@ -5,7 +5,7 @@
* *
* @group lint * @group lint
*/ */
final class ArcanistLintSummaryRenderer implements ArcanistLintRenderer { final class ArcanistLintSummaryRenderer extends ArcanistLintRenderer {
public function renderLintResult(ArcanistLintResult $result) { public function renderLintResult(ArcanistLintResult $result) {
$messages = $result->getMessages(); $messages = $result->getMessages();
$path = $result->getPath(); $path = $result->getPath();