From 2374403e8f80a8fb16cdc1ce2843f932632e8cf0 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 17 Jun 2016 07:49:07 -0700 Subject: [PATCH] Remove the "you have not specified reviewers" prompt from the `arc` client Summary: Ref T4631. Ref T10939. I don't have any good solutions here; this is perhaps the least-bad one. - This prompt is misleading/confusing in the presence of Herald/Owners. - This prompt is likely of very little value for experienced reviewers. - When it works, this prompt may be of some value for new reviewers, but getting it wrong is probably more confusing than getting it right is helpful, and there is a more accurate version of the warning in the web UI that new users are likely to see. - In the long run, this code should not live in the client. Test Plan: Created this revision without specifying reviewers, probably didn't get prompted. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4631, T10939 Differential Revision: https://secure.phabricator.com/D16139 --- src/workflow/ArcanistDiffWorkflow.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php index 3a631e88..64ab5c01 100644 --- a/src/workflow/ArcanistDiffWorkflow.php +++ b/src/workflow/ArcanistDiffWorkflow.php @@ -1815,12 +1815,7 @@ EOTEXT } $reviewers = $message->getFieldValue('reviewerPHIDs'); - if (!$reviewers) { - $confirm = pht('You have not specified any reviewers. Continue anyway?'); - if (!phutil_console_confirm($confirm)) { - throw new ArcanistUsageException(pht('Specify reviewers and retry.')); - } - } else { + if ($reviewers) { $futures['reviewers'] = $this->getConduit()->callMethod( 'user.query', array(