mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-29 10:12:41 +01:00
Remove the "you have not specified reviewers" prompt from the arc
client
Summary: Ref T4631. Ref T10939. I don't have any good solutions here; this is perhaps the least-bad one. - This prompt is misleading/confusing in the presence of Herald/Owners. - This prompt is likely of very little value for experienced reviewers. - When it works, this prompt may be of some value for new reviewers, but getting it wrong is probably more confusing than getting it right is helpful, and there is a more accurate version of the warning in the web UI that new users are likely to see. - In the long run, this code should not live in the client. Test Plan: Created this revision without specifying reviewers, probably didn't get prompted. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4631, T10939 Differential Revision: https://secure.phabricator.com/D16139
This commit is contained in:
parent
c13e5a6295
commit
2374403e8f
1 changed files with 1 additions and 6 deletions
|
@ -1815,12 +1815,7 @@ EOTEXT
|
||||||
}
|
}
|
||||||
|
|
||||||
$reviewers = $message->getFieldValue('reviewerPHIDs');
|
$reviewers = $message->getFieldValue('reviewerPHIDs');
|
||||||
if (!$reviewers) {
|
if ($reviewers) {
|
||||||
$confirm = pht('You have not specified any reviewers. Continue anyway?');
|
|
||||||
if (!phutil_console_confirm($confirm)) {
|
|
||||||
throw new ArcanistUsageException(pht('Specify reviewers and retry.'));
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
$futures['reviewers'] = $this->getConduit()->callMethod(
|
$futures['reviewers'] = $this->getConduit()->callMethod(
|
||||||
'user.query',
|
'user.query',
|
||||||
array(
|
array(
|
||||||
|
|
Loading…
Reference in a new issue