mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 08:52:39 +01:00
Minor performance optimization
Summary: Avoid using `idx` in `PhutilTestCase::endCoverage`. Test Plan: Compared [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-tgmc6ci74daivtankuck/?symbol=idx | before]] and [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-nd77mled6xnezyxidd6m/?symbol=idx | after]]. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13595
This commit is contained in:
parent
3d16595c07
commit
23a653e2bb
1 changed files with 4 additions and 1 deletions
|
@ -582,7 +582,10 @@ abstract class PhutilTestCase extends Phobject {
|
|||
$max = max(array_keys($report));
|
||||
$str = '';
|
||||
for ($ii = 1; $ii <= $max; $ii++) {
|
||||
$c = idx($report, $ii);
|
||||
$c = null;
|
||||
if (isset($report[$ii])) {
|
||||
$c = $report[$ii];
|
||||
}
|
||||
if ($c === -1) {
|
||||
$str .= 'U'; // Un-covered.
|
||||
} else if ($c === -2) {
|
||||
|
|
Loading…
Reference in a new issue