diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php index 7733393c..a6cb2f45 100644 --- a/src/lint/linter/ArcanistCSSLintLinter.php +++ b/src/lint/linter/ArcanistCSSLintLinter.php @@ -58,10 +58,6 @@ final class ArcanistCSSLintLinter extends ArcanistExternalLinter { 'npm install -g csslint'); } - public function shouldExpectCommandErrors() { - return true; - } - protected function parseLinterOutput($path, $err, $stdout, $stderr) { $report_dom = new DOMDocument(); $ok = @$report_dom->loadXML($stdout); diff --git a/src/lint/linter/ArcanistClosureLinter.php b/src/lint/linter/ArcanistClosureLinter.php index d437f3b6..e6f77187 100644 --- a/src/lint/linter/ArcanistClosureLinter.php +++ b/src/lint/linter/ArcanistClosureLinter.php @@ -37,10 +37,6 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter { 'files/closure_linter-latest.tar.gz'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return false; } diff --git a/src/lint/linter/ArcanistCoffeeLintLinter.php b/src/lint/linter/ArcanistCoffeeLintLinter.php index 75521623..9161fd14 100644 --- a/src/lint/linter/ArcanistCoffeeLintLinter.php +++ b/src/lint/linter/ArcanistCoffeeLintLinter.php @@ -47,10 +47,6 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter { 'npm install -g coffeelint'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistCppcheckLinter.php b/src/lint/linter/ArcanistCppcheckLinter.php index f4661b64..830452a5 100644 --- a/src/lint/linter/ArcanistCppcheckLinter.php +++ b/src/lint/linter/ArcanistCppcheckLinter.php @@ -67,6 +67,10 @@ final class ArcanistCppcheckLinter extends ArcanistExternalLinter { array('-j2', '--enable=performance,style,portability,information')); } + public function shouldExpectCommandErrors() { + return false; + } + protected function parseLinterOutput($path, $err, $stdout, $stderr) { $dom = new DOMDocument(); $ok = @$dom->loadXML($stderr); diff --git a/src/lint/linter/ArcanistCpplintLinter.php b/src/lint/linter/ArcanistCpplintLinter.php index 3f660066..0e3f5b66 100644 --- a/src/lint/linter/ArcanistCpplintLinter.php +++ b/src/lint/linter/ArcanistCpplintLinter.php @@ -29,10 +29,6 @@ final class ArcanistCpplintLinter extends ArcanistExternalLinter { 'googlecode.com/svn/trunk/cpplint/cpplint.py`.'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php index bcb7e1af..b6790d4f 100644 --- a/src/lint/linter/ArcanistExternalLinter.php +++ b/src/lint/linter/ArcanistExternalLinter.php @@ -56,7 +56,7 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter { * @task bin */ public function shouldExpectCommandErrors() { - return false; + return true; } /** diff --git a/src/lint/linter/ArcanistFlake8Linter.php b/src/lint/linter/ArcanistFlake8Linter.php index 658a6dd6..6c1c6d6f 100644 --- a/src/lint/linter/ArcanistFlake8Linter.php +++ b/src/lint/linter/ArcanistFlake8Linter.php @@ -58,10 +58,6 @@ final class ArcanistFlake8Linter extends ArcanistExternalLinter { return pht('Install flake8 using `easy_install flake8`.'); } - public function shouldExpectCommandErrors() { - return true; - } - protected function parseLinterOutput($path, $err, $stdout, $stderr) { $lines = phutil_split_lines($stdout, false); diff --git a/src/lint/linter/ArcanistGoLintLinter.php b/src/lint/linter/ArcanistGoLintLinter.php index 806bda6d..e886e05c 100644 --- a/src/lint/linter/ArcanistGoLintLinter.php +++ b/src/lint/linter/ArcanistGoLintLinter.php @@ -30,6 +30,10 @@ final class ArcanistGoLintLinter extends ArcanistExternalLinter { return pht('Install Golint using `go get github.com/golang/lint/golint`.'); } + public function shouldExpectCommandErrors() { + return false; + } + protected function canCustomizeLintSeverities() { return true; } diff --git a/src/lint/linter/ArcanistHLintLinter.php b/src/lint/linter/ArcanistHLintLinter.php index 312110d4..df22c25b 100644 --- a/src/lint/linter/ArcanistHLintLinter.php +++ b/src/lint/linter/ArcanistHLintLinter.php @@ -41,10 +41,6 @@ final class ArcanistHLintLinter extends ArcanistExternalLinter { return '-'; } - public function shouldExpectCommandErrors() { - return true; - } - protected function getMandatoryFlags() { return array('--json'); } diff --git a/src/lint/linter/ArcanistJSHintLinter.php b/src/lint/linter/ArcanistJSHintLinter.php index ea18e771..47483d4c 100644 --- a/src/lint/linter/ArcanistJSHintLinter.php +++ b/src/lint/linter/ArcanistJSHintLinter.php @@ -73,10 +73,6 @@ final class ArcanistJSHintLinter extends ArcanistExternalLinter { return pht('Install JSHint using `npm install -g jshint`.'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistJSONLintLinter.php b/src/lint/linter/ArcanistJSONLintLinter.php index 254f8b31..064782f8 100644 --- a/src/lint/linter/ArcanistJSONLintLinter.php +++ b/src/lint/linter/ArcanistJSONLintLinter.php @@ -47,10 +47,6 @@ final class ArcanistJSONLintLinter extends ArcanistExternalLinter { return pht('Install jsonlint using `npm install -g jsonlint`.'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistJscsLinter.php b/src/lint/linter/ArcanistJscsLinter.php index 97ec382d..cc037214 100644 --- a/src/lint/linter/ArcanistJscsLinter.php +++ b/src/lint/linter/ArcanistJscsLinter.php @@ -45,10 +45,6 @@ final class ArcanistJscsLinter extends ArcanistExternalLinter { return pht('Install JSCS using `npm install -g jscs`.'); } - public function shouldExpectCommandErrors() { - return true; - } - protected function getMandatoryFlags() { $options = array(); diff --git a/src/lint/linter/ArcanistLesscLinter.php b/src/lint/linter/ArcanistLesscLinter.php index 00a40436..f225bb35 100644 --- a/src/lint/linter/ArcanistLesscLinter.php +++ b/src/lint/linter/ArcanistLesscLinter.php @@ -101,10 +101,6 @@ final class ArcanistLesscLinter extends ArcanistExternalLinter { return pht('Install lessc using `npm install -g less`.'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { // Technically `lessc` can read data from standard input however, when doing // so, relative imports cannot be resolved. Therefore, this functionality is diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php index 51608277..82ab607f 100644 --- a/src/lint/linter/ArcanistPEP8Linter.php +++ b/src/lint/linter/ArcanistPEP8Linter.php @@ -70,10 +70,6 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter { return pht('Install PEP8 using `easy_install pep8`.'); } - public function shouldExpectCommandErrors() { - return true; - } - protected function parseLinterOutput($path, $err, $stdout, $stderr) { $lines = phutil_split_lines($stdout, false); diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php index 438cfe6e..328e87ce 100644 --- a/src/lint/linter/ArcanistPhpLinter.php +++ b/src/lint/linter/ArcanistPhpLinter.php @@ -55,10 +55,6 @@ final class ArcanistPhpLinter extends ArcanistExternalLinter { return $stdout; } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return false; } diff --git a/src/lint/linter/ArcanistPhpcsLinter.php b/src/lint/linter/ArcanistPhpcsLinter.php index e9aefe45..220719ed 100644 --- a/src/lint/linter/ArcanistPhpcsLinter.php +++ b/src/lint/linter/ArcanistPhpcsLinter.php @@ -68,10 +68,6 @@ final class ArcanistPhpcsLinter extends ArcanistExternalLinter { } } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistPuppetLintLinter.php b/src/lint/linter/ArcanistPuppetLintLinter.php index 2cc39a40..ea5b66cf 100644 --- a/src/lint/linter/ArcanistPuppetLintLinter.php +++ b/src/lint/linter/ArcanistPuppetLintLinter.php @@ -52,10 +52,6 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter { 'gem install puppet-lint'); } - public function shouldExpectCommandErrors() { - return true; - } - protected function getMandatoryFlags() { return array( '--error-level=all', diff --git a/src/lint/linter/ArcanistPyFlakesLinter.php b/src/lint/linter/ArcanistPyFlakesLinter.php index fe047c50..4180fc90 100644 --- a/src/lint/linter/ArcanistPyFlakesLinter.php +++ b/src/lint/linter/ArcanistPyFlakesLinter.php @@ -53,10 +53,6 @@ final class ArcanistPyFlakesLinter extends ArcanistExternalLinter { return pht('Install pyflakes with `pip install pyflakes`.'); } - public function shouldExpectCommandErrors() { - return true; - } - public function supportsReadDataFromStdin() { return true; } diff --git a/src/lint/linter/ArcanistRubyLinter.php b/src/lint/linter/ArcanistRubyLinter.php index 27847220..bdf3ab82 100644 --- a/src/lint/linter/ArcanistRubyLinter.php +++ b/src/lint/linter/ArcanistRubyLinter.php @@ -54,10 +54,6 @@ final class ArcanistRubyLinter extends ArcanistExternalLinter { return true; } - public function shouldExpectCommandErrors() { - return true; - } - protected function getMandatoryFlags() { // -w: turn on warnings // -c: check syntax