From 24ab7b7f38e3b7d236ed03fbaf5bb7d12b29e8ac Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Tue, 3 Feb 2015 08:01:11 +1100 Subject: [PATCH] Allow `ArcanistPhutilLibraryLinter` to run with an out-of-date XHPAST binary Summary: There is no need to check if the XHPAST binary is available here because this linter does not actually parse PHP, it only considers the library map. Test Plan: Removed the XHPAST binary and ran `arc lint` on a bunch of files. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11528 --- src/lint/linter/ArcanistPhutilLibraryLinter.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/lint/linter/ArcanistPhutilLibraryLinter.php b/src/lint/linter/ArcanistPhutilLibraryLinter.php index 0e9ca2b3..baee3ba3 100644 --- a/src/lint/linter/ArcanistPhutilLibraryLinter.php +++ b/src/lint/linter/ArcanistPhutilLibraryLinter.php @@ -51,10 +51,6 @@ final class ArcanistPhutilLibraryLinter extends ArcanistLinter { } public function willLintPaths(array $paths) { - if (!xhpast_is_available()) { - throw new Exception(xhpast_get_build_instructions()); - } - // NOTE: For now, we completely ignore paths and just lint every library in // its entirety. This is simpler and relatively fast because we don't do any // detailed checks and all the data we need for this comes out of module