(stable) Promote 2019 Week 20

src/lint/linter/ArcanistExternalLinter.php

@@ -410,7 +410,7 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
     return csprintf('%s', $path);
   }
 
-  final protected function buildFutures(array $paths) {
+  protected function buildFutures(array $paths) {
     $executable = $this->getExecutableCommand();
 
     $bin = csprintf('%C %Ls', $executable, $this->getCommandFlags());
@@ -428,7 +428,7 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
     return $futures;
   }
 
-  final protected function resolveFuture($path, Future $future) {
+  protected function resolveFuture($path, Future $future) {
     list($err, $stdout, $stderr) = $future->resolve();
     if ($err && !$this->shouldExpectCommandErrors()) {
       $future->resolvex();

src/lint/linter/ArcanistLinter.php

@@ -214,9 +214,6 @@ abstract class ArcanistLinter extends Phobject {
     return 1.0;
   }
 
-  /**
-   * TODO: This should be `final`.
-   */
   public function setCustomSeverityMap(array $map) {
     $this->customSeverityMap = $map;
     return $this;
@@ -227,7 +224,7 @@ abstract class ArcanistLinter extends Phobject {
     return $this;
   }
 
-  final public function setCustomSeverityRules(array $rules) {
+  public function setCustomSeverityRules(array $rules) {
     $this->customSeverityRules = $rules;
     return $this;
   }

src/lint/linter/ArcanistPyLintLinter.php

@@ -38,7 +38,7 @@ final class ArcanistPyLintLinter extends ArcanistExternalLinter {
     list($stdout) = execx('%C --version', $this->getExecutableCommand());
 
     $matches = array();
-    $regex = '/^pylint (?P<version>\d+\.\d+\.\d+),/';
+    $regex = '/^pylint (?P<version>\d+\.\d+\.\d+)/';
     if (preg_match($regex, $stdout, $matches)) {
       return $matches['version'];
     } else {

src/lint/linter/__tests__/ArcanistLinterTestCase.php

@@ -114,6 +114,7 @@ abstract class ArcanistLinterTestCase extends PhutilTestCase {
       $path_name = idx($config, 'path', $path);
       $engine->setPaths(array($path_name));
 
+      $linter->setEngine($engine);
       $linter->addPath($path_name);
       $linter->addData($path_name, $data);
 

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

@@ -17,6 +17,9 @@ final class ArcanistClassNameLiteralXHPASTLinterRule
     $class_declarations = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
 
     foreach ($class_declarations as $class_declaration) {
+      if ($class_declaration->getChildByIndex(1)->getTypeName() == 'n_EMPTY') {
+        continue;
+      }
       $class_name = $class_declaration
         ->getChildOfType(1, 'n_CLASS_NAME')
         ->getConcreteString();

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

@@ -20,7 +20,9 @@ final class ArcanistConstructorParenthesesXHPASTLinterRule
       $class  = $node->getChildByIndex(0);
       $params = $node->getChildByIndex(1);
 
-      if ($params->getTypeName() == 'n_EMPTY') {
+      if ($class->getTypeName() != 'n_CLASS_DECLARATION' &&
+        $params->getTypeName() == 'n_EMPTY') {
+
         $this->raiseLintAtNode(
           $class,
           pht('Use parentheses when invoking a constructor.'),

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

@@ -17,6 +17,9 @@ final class ArcanistSelfClassReferenceXHPASTLinterRule
     $class_declarations = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
 
     foreach ($class_declarations as $class_declaration) {
+      if ($class_declaration->getChildByIndex(1)->getTypeName() == 'n_EMPTY') {
+        continue;
+      }
       $class_name = $class_declaration
         ->getChildOfType(1, 'n_CLASS_NAME')
         ->getConcreteString();

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

@@ -17,6 +17,9 @@ final class ArcanistUnnecessaryFinalModifierXHPASTLinterRule
     $classes = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
 
     foreach ($classes as $class) {
+      if ($class->getChildByIndex(0)->getTypeName() == 'n_EMPTY') {
+        continue;
+      }
       $attributes = $class->getChildOfType(0, 'n_CLASS_ATTRIBUTES');
       $is_final = false;
 

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

@@ -11,6 +11,12 @@ class MyClass {
     return __CLASS__;
   }
 }
+
+$c = new class {
+  public function someMethod() {
+    return __CLASS__;
+  }
+};
 ~~~~~~~~~~
 advice:5:12
 advice:9:10
@@ -28,3 +34,9 @@ class MyClass {
     return __CLASS__;
   }
 }
+
+$c = new class {
+  public function someMethod() {
+    return __CLASS__;
+  }
+};

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

@@ -3,6 +3,7 @@
 new Foo;
 new Bar();
 new Foo\Bar;
+new class {};
 ~~~~~~~~~~
 advice:3:5
 advice:5:5
@@ -12,3 +13,4 @@ advice:5:5
 new Foo();
 new Bar();
 new Foo\Bar();
+new class {};

src/lint/linter/xhpast/rules/__tests__/self-class-reference/self-class-references.lint-test

@@ -9,6 +9,12 @@ class Foo extends Bar {
     return new self();
   }
 }
+
+$c = new class {
+  public function newInstance() {
+    return new self();
+  }
+};
 ~~~~~~~~~~
 warning:5:16
 ~~~~~~~~~~
@@ -23,3 +29,9 @@ class Foo extends Bar {
     return new self();
   }
 }
+
+$c = new class {
+  public function newInstance() {
+    return new self();
+  }
+};

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

@@ -4,5 +4,6 @@ final class Foo {
   public function bar() {}
   final public function baz() {}
 }
+$c = new class {};
 ~~~~~~~~~~
 advice:5:3

src/workflow/ArcanistLandWorkflow.php

@@ -1376,6 +1376,7 @@ EOTEXT
     // if this one doesn't work out.
     try {
       $this->checkForBuildablesWithPlanBehaviors($diff_phid);
+      return;
     } catch (ArcanistUserAbortException $abort_ex) {
       throw $abort_ex;
     } catch (Exception $ex) {