revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Make the behavior of "--load-phutil-library" more explicit

Browse source 
Summary:
This flag disables normal libraries to make it easier to test library changes. Print that out explicitly.

Also update `.arcconfig` to use the modern configuration format.

Test Plan: Ran `arc list --trace`, `arc list --load-phutil-library=src --trace`.

Reviewers: zeeg, btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5768
This commit is contained in:
epriestley 2013-04-29 12:19:15 -07:00
parent 28df67963b
commit 270f2402de
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.arcconfig
View file

@ -3,7 +3,7 @@
"conduit_uri" : "https://secure.phabricator.com/", "conduit_uri" : "https://secure.phabricator.com/",
"lint.engine" : "PhutilLintEngine", "lint.engine" : "PhutilLintEngine",
"unit.engine" : "PhutilUnitTestEngine", "unit.engine" : "PhutilUnitTestEngine",
"phutil_libraries" : { "load" : [
"arcanist" : "src/" "src/"
} ]
} }

3
scripts/arcanist.php
View file

@ -96,6 +96,9 @@ try {
// is configured. This is basically a debugging feature to let you force // is configured. This is basically a debugging feature to let you force
// specific libraries to load regardless of the state of the world. // specific libraries to load regardless of the state of the world.
if ($load) { if ($load) {
$console->writeLog(
"Using '--load-phutil-library' flag, configuration will be ignored ".
"and configured libraries will not be loaded."."\n");
// Load the flag libraries. These must load, since the user specified them // Load the flag libraries. These must load, since the user specified them
// explicitly. // explicitly.
arcanist_load_libraries( arcanist_load_libraries(