revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 14:22:40 +01:00
Code Issues Releases Wiki Activity

Fix invalid constructor call for ArcanistHardpointFutureList

Browse source 
Summary:
`ArcanistHardpointFutureList` does not have a constructor and must be instantiated without any parameters.
As the code checks `if ($result instanceof Future)` and tries to pass `$result` as a parameter, the intention seems to be calling `newFromFutures($result)` on the new `ArcanistHardpointFutureList` instance.

Closes T15836

Test Plan: Read the code in `ArcanistHardpointFutureList`.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15836

Differential Revision: https://we.phorge.it/D25708
This commit is contained in:
Andre Klapper 2024-09-30 15:36:10 +02:00
parent 0358ff7ee3
commit 285e31f4c7
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/hardpoint/ArcanistHardpointTask.php
View file

@ -105,7 +105,8 @@ final class ArcanistHardpointTask
$result = $generator->current(); $result = $generator->current();
if ($result instanceof Future) { if ($result instanceof Future) {
$result = new ArcanistHardpointFutureList($result); $result =
ArcanistHardpointFutureList::newFromFutures(array($result));
} }
if ($result instanceof ArcanistHardpointFutureList) { if ($result instanceof ArcanistHardpointFutureList) {