1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-25 23:10:56 +01:00

Check that rev is accepted in arc mark-committed --finalize

Summary:
If arc amend is run on a rev that isn't accepted, it runs arc mark-committed
--finalize. The rev shouldn't be marked as committed if it hasn't been accepted,
so this diff adds in that check.

Test Plan:
Ran arc amend on a rev that hasn't been accepted, checked that it didn't get
marked as completed.

Reviewers: jungejason, epriestley

Reviewed By: epriestley

CC: aran, epriestley, nh

Differential Revision: 1104
This commit is contained in:
Nick Harper 2011-11-10 16:02:40 -08:00
parent 8c70ee3877
commit 28eae60821

View file

@ -121,7 +121,7 @@ EOTEXT
array(
'name' => $this->getWorkingCopy()->getProjectID(),
));
if ($project_info['tracked']) {
if ($project_info['tracked'] || $revision['statusName'] != 'Accepted') {
$actually_mark = false;
}
}