revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Catch "ConduitClientException", not "Exception", in "arc patch"

Browse source 
Summary: This may raise other types of exceptions, e.g. http/network exceptions, where getErrorCode() is not defined.

Test Plan: Reasoned about beahvior.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1804
This commit is contained in:
epriestley 2012-03-06 20:14:34 -08:00
parent 81019a790e
commit 2c26304dd2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/patch/ArcanistPatchWorkflow.php
View file

@ -349,7 +349,7 @@ EOTEXT
$param); $param);
break; break;
} }
} catch (Exception $ex) { } catch (ConduitClientException $ex) {
if ($ex->getErrorCode() == 'ERR-INVALID-SESSION') { if ($ex->getErrorCode() == 'ERR-INVALID-SESSION') {
// Phabricator is not configured to allow anonymous access to // Phabricator is not configured to allow anonymous access to
// Differential. // Differential.