revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Disallow using DD1 as revision ID

Browse source 
Test Plan:
  $ arc inlines --revision 1
  $ arc inlines --revision D1
  $ arc inlines --revision DD1

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3811
This commit is contained in:
vrana 2012-10-24 11:23:10 -07:00
parent 448e820eb6
commit 2d226f3110
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistBaseWorkflow.php
View file

@ -954,7 +954,7 @@ abstract class ArcanistBaseWorkflow {
} }
protected function normalizeRevisionID($revision_id) { protected function normalizeRevisionID($revision_id) {
return ltrim(strtoupper($revision_id), 'D'); return preg_replace('/^D/i', '', $revision_id);
} }
protected function shouldShellComplete() { protected function shouldShellComplete() {