1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00

Improve resolution behaviors of FutureProxy

Summary:
See PHI1764. See PHI1802. Address two resolution behaviors for FutureProxy:

  - FutureProxy may throw an exception directly from iteration via "FutureIterator" (see PHI1764). This is wrong: futures should throw only when resolved.
  - FutureProxy can not change an exception into a result, or a result into an exception, or an exception into a different exception. Being able to proxy the full range of result and exception behavior is useful, particularly for Conduit (see PHI1802).

Make "FutureProxy" more robust in how it handles exceptions from proxied futures.

Test Plan:
Used this script to raise an exception during result processing:

```
<?php

require_once 'support/init/init-script.php';

final class ThrowingFutureProxy
  extends FutureProxy {

  protected function didReceiveResult($result) {
    throw new Exception('!');
  }

}

$future = new ImmediateFuture('quack');
$proxy = new ThrowingFutureProxy($future);
$iterator = new FutureIterator(array($proxy));

foreach ($iterator as $resolved) {
  try {
    $resolved->resolve();
  } catch (Exception $ex) {
    echo "Caught exception properly on resolution.\n";
  }
}
```

Before this change, the exception is raised in the `foreach()` loop. After this change, the exception is raised at resolution time.

Differential Revision: https://secure.phabricator.com/D21383
This commit is contained in:
epriestley 2020-07-01 05:06:19 -07:00
parent 98ca5cfa81
commit 2daf9b16ae
2 changed files with 19 additions and 13 deletions

View file

@ -63,7 +63,7 @@ abstract class Future extends Phobject {
$this->hasStarted = true;
$this->startServiceProfiler();
$this->isReady();
$this->updateFuture();
}
final public function updateFuture() {

View file

@ -27,27 +27,29 @@ abstract class FutureProxy extends Future {
}
public function isReady() {
if ($this->hasResult()) {
if ($this->hasResult() || $this->hasException()) {
return true;
}
$proxied = $this->getProxiedFuture();
$proxied->updateFuture();
$is_ready = $proxied->isReady();
if ($proxied->hasResult() || $proxied->hasException()) {
try {
$result = $proxied->resolve();
$result = $this->didReceiveResult($result);
} catch (Exception $ex) {
$result = $this->didReceiveException($ex);
} catch (Throwable $ex) {
$result = $this->didReceiveException($ex);
}
if ($proxied->hasResult()) {
$result = $proxied->getResult();
$result = $this->didReceiveResult($result);
$this->setResult($result);
return true;
}
return $is_ready;
}
public function resolve() {
$this->getProxiedFuture()->resolve();
$this->isReady();
return $this->getResult();
return false;
}
public function getReadSockets() {
@ -73,4 +75,8 @@ abstract class FutureProxy extends Future {
abstract protected function didReceiveResult($result);
protected function didReceiveException($exception) {
throw $exception;
}
}