revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-02 09:58:23 +01:00
Code Issues Releases Wiki Activity

Add canRun to linters.

Browse source 
Summary:
This allows engines to check the canRun method on linters,
which should determine if a linter is configured and can
be run in the current environment.

Test Plan:
Implement a linter with canRun as false, and ensure
it doesnt run.

Ensure all existing linters still run by default.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D1445
This commit is contained in:
David Cramer 2012-01-17 16:30:59 -08:00
parent 9be9554f2d
commit 2fa80bbd44
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/__phutil_library_map__.php
View file

@ -99,7 +99,7 @@ phutil_register_library_map(array(
'ArcanistXHPASTLinter' => 'lint/linter/xhpast', 'ArcanistXHPASTLinter' => 'lint/linter/xhpast',
'ArcanistXHPASTLinterTestCase' => 'lint/linter/xhpast/__tests__', 'ArcanistXHPASTLinterTestCase' => 'lint/linter/xhpast/__tests__',
'BranchInfo' => 'branch', 'BranchInfo' => 'branch',
'ComprehensiveEngine' => 'lint/engine/comprehensive', 'ComprehensiveLintEngine' => 'lint/engine/comprehensive',
'ExampleLintEngine' => 'lint/engine/example', 'ExampleLintEngine' => 'lint/engine/example',
'PhutilLintEngine' => 'lint/engine/phutil', 'PhutilLintEngine' => 'lint/engine/phutil',
'PhutilModuleRequirements' => 'parser/phutilmodule', 'PhutilModuleRequirements' => 'parser/phutilmodule',
@ -166,7 +166,7 @@ phutil_register_library_map(array(
'ArcanistUserAbortException' => 'ArcanistUsageException', 'ArcanistUserAbortException' => 'ArcanistUsageException',
'ArcanistXHPASTLinter' => 'ArcanistLinter', 'ArcanistXHPASTLinter' => 'ArcanistLinter',
'ArcanistXHPASTLinterTestCase' => 'ArcanistLinterTestCase', 'ArcanistXHPASTLinterTestCase' => 'ArcanistLinterTestCase',
'ComprehensiveEngine' => 'ArcanistLintEngine', 'ComprehensiveLintEngine' => 'ArcanistLintEngine',
'ExampleLintEngine' => 'ArcanistLintEngine', 'ExampleLintEngine' => 'ArcanistLintEngine',
'PhutilLintEngine' => 'ArcanistLintEngine', 'PhutilLintEngine' => 'ArcanistLintEngine',
'PhutilUnitTestEngine' => 'ArcanistBaseUnitTestEngine', 'PhutilUnitTestEngine' => 'ArcanistBaseUnitTestEngine',

3
src/lint/engine/base/ArcanistLintEngine.php
View file

@ -183,6 +183,9 @@ abstract class ArcanistLintEngine {
foreach ($linters as $linter) { foreach ($linters as $linter) {
$linter->setEngine($this); $linter->setEngine($this);
if (!$linter->canRun()) {
continue;
}
$paths = $linter->getPaths(); $paths = $linter->getPaths();
foreach ($paths as $key => $path) { foreach ($paths as $key => $path) {

4
src/lint/linter/base/ArcanistLinter.php
View file

@ -186,6 +186,10 @@ abstract class ArcanistLinter {
$this->activePath = $path; $this->activePath = $path;
} }
public function canRun() {
return true;
}
abstract public function willLintPaths(array $paths); abstract public function willLintPaths(array $paths);
abstract public function lintPath($path); abstract public function lintPath($path);
abstract public function getLinterName(); abstract public function getLinterName();