Use assert_instances_of()

Summary: D2042

Test Plan:
- `arc lint` with dependent message
- `arc liberate`
- `arc diff`

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2048

src/lint/message/ArcanistLintMessage.php

@@ -188,6 +188,7 @@ final class ArcanistLintMessage {
   }
 
   public function setDependentMessages(array $messages) {
+    assert_instances_of($messages, 'ArcanistLintMessage');
     $this->dependentMessages = $messages;
     return $this;
   }

src/lint/message/__init__.php

@@ -5,7 +5,10 @@
  */
 
 
+
 phutil_require_module('arcanist', 'lint/severity');
 
+phutil_require_module('phutil', 'utils');
+
 
 phutil_require_source('ArcanistLintMessage.php');

src/parser/bundle/ArcanistBundle.php

@@ -546,7 +546,7 @@ final class ArcanistBundle {
   }
 
   private function buildHunkChanges(array $hunks) {
-
+    assert_instances_of($hunks, 'ArcanistDiffHunk');
     $result = array();
     foreach ($hunks as $hunk) {
       $small_hunks = $this->breakHunkIntoSmallHunks($hunk);

src/parser/diff/ArcanistDiffParser.php

@@ -58,6 +58,7 @@ final class ArcanistDiffParser {
   }
 
   public function setChanges(array $changes) {
+    assert_instances_of($changes, 'ArcanistDiffChange');
     $this->changes = mpull($changes, null, 'getCurrentPath');
     return $this;
   }

src/workflow/liberate/ArcanistLiberateWorkflow.php

@@ -202,6 +202,7 @@ EOTEXT
   }
 
   private function liberateWritePatches(array $results) {
+    assert_instances_of($results, 'ArcanistLintResult');
     $wrote = array();
 
     foreach ($results as $result) {