1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00

two small changes for "arc unit" post hook

Summary:
1) unit engine getter method in the unit workflow

   we store some information (unit test results) in the engine that we
   need to access in the "arc unit" post hook

2) make requireCleanWorkingCopy() public

   "arc unit" doesn't need to be clean in general, but we'd like the
   option to upgrade the workflow to require it if necessary.  We use
   this for ensuring a repo is clean before updating unit test
   results.

Test Plan: Used both features in a custom post hook in arc unit

Reviewers: epriestley

Reviewed By: epriestley

CC: dpepper, aran, epriestley

Differential Revision: 917
This commit is contained in:
mgummelt 2011-09-08 17:36:20 -07:00
parent 2d50e08ee6
commit 3250cbb4d3
2 changed files with 5 additions and 1 deletions

View file

@ -573,7 +573,7 @@ class ArcanistBaseWorkflow {
return empty($this->arguments['allow-untracked']);
}
protected function requireCleanWorkingCopy() {
public function requireCleanWorkingCopy() {
$api = $this->getRepositoryAPI();
$working_copy_desc = phutil_console_format(

View file

@ -60,6 +60,10 @@ EOTEXT
return true;
}
public function getEngine() {
return $this->engine;
}
public function run() {
$working_copy = $this->getWorkingCopy();