revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-01 10:20:58 +01:00
Code Issues Releases Wiki Activity

Remove "async lint" from arc lint

Browse source 
Summary: Ref T12996. This was a very old FB-specific feature that caused some kind of server-side lint thing to run. You can/should do this now with Harbormaster instead. Nothing else ever used it and it has no role in the upstream.

Test Plan: Grepped for `asynclint`, created this revision.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12996

Differential Revision: https://secure.phabricator.com/D18641
This commit is contained in:
epriestley 2017-09-25 11:07:20 -07:00
parent d446517d5e
commit 3453ef8358
2 changed files with 0 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/lint/engine/ArcanistLintEngine.php
View file

@ -56,7 +56,6 @@ abstract class ArcanistLintEngine extends Phobject {
private $changedLines = array();
private $enableAsyncLint = false;
private $configurationManager;
private $linterResources = array();
@ -110,15 +109,6 @@ abstract class ArcanistLintEngine extends Phobject {
return $this;
}
final public function setEnableAsyncLint($enable_async_lint) {
$this->enableAsyncLint = $enable_async_lint;
return $this;
}
final public function getEnableAsyncLint() {
return $this->enableAsyncLint;
}
final public function loadData($path) {
if (!isset($this->fileData[$path])) {
$disk_path = $this->getFilePathOnDisk($path);

7
src/workflow/ArcanistLintWorkflow.php
View file

@ -286,13 +286,6 @@ EOTEXT
}
}
// Enable possible async linting only for 'arc diff' not 'arc lint'
if ($this->getParentWorkflow()) {
$engine->setEnableAsyncLint(true);
} else {
$engine->setEnableAsyncLint(false);
}
if ($this->getArgument('only-new')) {
$conduit = $this->getConduit();
$api = $this->getRepositoryAPI();