revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Improve arc lint --output summary

Browse source 
Summary:
This currently output like this:

  file_a:
  file_b:
  file_c:
    Warning on line 29: blah blah

This isn't especially useful and can't be piped to other tools. Instead, emit output like:

  file_c:29:Warning: blah blah

This is greppable / pipeable.

Test Plan: Ran `arc lint --output summary`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7788
This commit is contained in:
epriestley 2013-12-18 14:21:03 -08:00
parent 8e177c4db8
commit 35c01eee7b
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/lint/renderer/ArcanistLintSummaryRenderer.php
View file

@ -11,18 +11,16 @@ final class ArcanistLintSummaryRenderer extends ArcanistLintRenderer {
$path = $result->getPath(); $path = $result->getPath();
$text = array(); $text = array();
$text[] = $path.":";
foreach ($messages as $message) { foreach ($messages as $message) {
$name = $message->getName(); $name = $message->getName();
$severity = ArcanistLintSeverity::getStringForSeverity( $severity = ArcanistLintSeverity::getStringForSeverity(
$message->getSeverity()); $message->getSeverity());
$line = $message->getLine(); $line = $message->getLine();
$text[] = " {$severity} on line {$line}: {$name}"; $text[] = "{$path}:{$line}:{$severity}: {$name}\n";
} }
$text[] = null;
return implode("\n", $text); return implode("", $text);
} }
public function renderOkayResult() { public function renderOkayResult() {