revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-21 11:09:02 +01:00
Code Issues Releases Wiki Activity

Don't interpret arc browse . as a commit

Browse source 
Summary: Ref T5781. `git show .` works like HEAD, but that isn't what `arc browse .` means.

Test Plan: Ran `arc browse .` with a repository at a published commit.

Reviewers: chad, btrahan, avive, avivey

Reviewed By: avivey

Subscribers: epriestley, avivey

Maniphest Tasks: T5781

Differential Revision: https://secure.phabricator.com/D10197
This commit is contained in:
epriestley 2014-08-08 11:21:43 -07:00
parent 7bd57bfd9c
commit 377eb5d1e0
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/repository/api/ArcanistGitAPI.php
View file

@ -535,7 +535,7 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
$stdout = $this->getHashFromFromSVNRevisionNumber($match[1]); $stdout = $this->getHashFromFromSVNRevisionNumber($match[1]);
} else { } else {
list($stdout) = $this->execxLocal( list($stdout) = $this->execxLocal(
'show -s --format=%C %s', 'show -s --format=%s %s --',
'%H', '%H',
$string); $string);
} }

16
src/workflow/ArcanistBrowseWorkflow.php
View file

@ -104,9 +104,19 @@ EOTEXT
$commits = array(); $commits = array();
foreach ($things as $key => $thing) { foreach ($things as $key => $thing) {
$commit = $repository_api->getCanonicalRevisionName($thing); if ($thing == '.') {
if ($commit) { // Git resolves '.' like HEAD, but it should be interpreted to mean
$commits[$commit] = $key; // "the current directory". Just skip resolution and fall through.
continue;
}
try {
$commit = $repository_api->getCanonicalRevisionName($thing);
if ($commit) {
$commits[$commit] = $key;
}
} catch (Exception $ex) {
// Ignore.
} }
} }