revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Properly URL encode branches in arc browse --branch ...

Browse source 
Summary: Fixes T10511. If you `arc browse --branch x/y/z`, we do not encode the URI properly.

Test Plan:
Ran `arc browse --branch x/y/z/ something.c`.

Before, got an error about "x" does not exist. This is wrong; the error should be about "x/y/z".

After, got the proper error:

{F1141096}

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T10511

Differential Revision: https://secure.phabricator.com/D15397
This commit is contained in:
epriestley 2016-03-04 15:49:35 -08:00
parent b1de04aa68
commit 3876d93583
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/workflow/ArcanistBrowseWorkflow.php
View file

@ -225,6 +225,7 @@ EOTEXT
} }
$branch = $this->getArgument('branch', 'master'); $branch = $this->getArgument('branch', 'master');
$branch = phutil_escape_uri_path_component($branch);
return $repo_uri.'browse/'.$branch.'/'; return $repo_uri.'browse/'.$branch.'/';
} }